Skip to content

Commit 329383f

Browse files
feature #62027 [DebugBundle][HttpKernel] Collect dumps when console profiling is enabled (HypeMC)
This PR was merged into the 7.4 branch. Discussion ---------- [DebugBundle][HttpKernel] Collect dumps when console profiling is enabled | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | yes | Deprecations? | no | Issues | Fix #61971 | License | MIT Currently, when profiling a console command, calls to `dump()` aren't collected. With this PR, they'll be collected when profiling is enabled, or output directly when it's not. Not entirely sure whether this should be considered a bug or simply a missing feature. Commits ------- c4f80916902 [HttpKernel][DebugBundle] Collect dumps when console profiling is enabled
2 parents 5c5911a + 435a382 commit 329383f

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
7.4
5+
---
6+
7+
* Wire the `$profilerDumper` argument in `DumpListener`
8+
49
4.1.0
510
-----
611

Resources/config/services.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,17 @@
6060
'priority' => 240,
6161
])
6262

63+
->set('.lazy.data_collector.dump', DumpDataCollector::class)
64+
->factory('current')
65+
->args([[service('data_collector.dump')]])
66+
->lazy()
67+
6368
->set('debug.dump_listener', DumpListener::class)
6469
->args([
6570
service('var_dumper.cloner'),
6671
service('var_dumper.cli_dumper'),
6772
null,
73+
service('.lazy.data_collector.dump'),
6874
])
6975
->tag('kernel.event_subscriber')
7076

0 commit comments

Comments
 (0)