Display source code using dark mode #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks better 👍 |
javiereguiluz
force-pushed
the
dark_mode_code
branch
2 times, most recently
from
d181022 to
960c779
Compare
This is the main argument here, it makes it stand out more from the rest of the app. |
javiereguiluz
force-pushed
the
dark_mode_code
branch
from
960c779 to
0e1ff29
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a "dark mode" style for this application is outside of the scope of the project, so we're not going to do it.
However, I propose to use a "dark mode" style to display the source code in the modal windows. In addition to being the most common style for developers, showing it in "dark mode" further emphasizes the difference between the application interface and its code:
Before / After