services: added name to the quote #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's clear it's name of the filter and not English. I was about to send PR with space "localized date", but then I've read the "filter". So I hope this is the correct option :)
|
@TomasVotruba thanks for this. Adding quotes makes this impossible to misunderstand. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Jun 25, 2017
This PR was merged into the master branch. Discussion ---------- services: added name to the quote So it's clear it's name of the filter and not English. I was about to send PR with space "localized date", but then I've read the "filter". So I hope this is the correct option :) Commits ------- b9963c5 services: added name to the quote
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's clear it's name of the filter and not English.
I was about to send PR with space "localized date", but then I've read the "filter". So I hope this is the correct option :)