[Http-Kernel][5.0] Add type-hints

Author: Philippe Segatori

CacheClearer/CacheClearerInterface.php

@@ -20,8 +20,6 @@ interface CacheClearerInterface
 {
     /**
      * Clears any caches necessary.
-     *
-     * @param string $cacheDir The cache directory
      */
-    public function clear($cacheDir);
+    public function clear(string $cacheDir);
 }

CacheClearer/ChainCacheClearer.php

@@ -30,7 +30,7 @@ public function __construct(iterable $clearers = [])
     /**
      * {@inheritdoc}
      */
-    public function clear($cacheDir)
+    public function clear(string $cacheDir)
     {
         foreach ($this->clearers as $clearer) {
             $clearer->clear($cacheDir);

CacheClearer/Psr6CacheClearer.php

@@ -49,7 +49,7 @@ public function clearPool($name)
     /**
      * {@inheritdoc}
      */
-    public function clear($cacheDir)
+    public function clear(string $cacheDir)
     {
         foreach ($this->pools as $pool) {
             $pool->clear();

CacheWarmer/CacheWarmerAggregate.php

@@ -45,10 +45,8 @@ public function enableOnlyOptionalWarmers()
 
     /**
      * Warms up the cache.
-     *
-     * @param string $cacheDir The cache directory
      */
-    public function warmUp($cacheDir)
+    public function warmUp(string $cacheDir)
     {
         if ($collectDeprecations = $this->debug && !\defined('PHPUNIT_COMPOSER_INSTALL')) {
             $collectedLogs = [];

Controller/ArgumentResolver.php

@@ -43,7 +43,7 @@ public function __construct(ArgumentMetadataFactoryInterface $argumentMetadataFa
     /**
      * {@inheritdoc}
      */
-    public function getArguments(Request $request, $controller): array
+    public function getArguments(Request $request, callable $controller): array
     {
         $arguments = [];
 

Controller/ArgumentResolverInterface.php

@@ -30,5 +30,5 @@ interface ArgumentResolverInterface
      *
      * @throws \RuntimeException When no value could be provided for a required argument
      */
-    public function getArguments(Request $request, $controller);
+    public function getArguments(Request $request, callable $controller);
 }

Controller/ContainerControllerResolver.php

@@ -32,7 +32,7 @@ public function __construct(ContainerInterface $container, LoggerInterface $logg
         parent::__construct($logger);
     }
 
-    protected function createController($controller)
+    protected function createController(string $controller)
     {
         if (1 === substr_count($controller, ':')) {
             $controller = str_replace(':', '::', $controller);
@@ -45,7 +45,7 @@ protected function createController($controller)
     /**
      * {@inheritdoc}
      */
-    protected function instantiateController($class)
+    protected function instantiateController(string $class)
     {
         if ($this->container->has($class)) {
             return $this->container->get($class);

Controller/ControllerResolver.php

@@ -94,11 +94,9 @@ public function getController(Request $request)
     /**
      * Returns a callable for the given controller.
      *
-     * @param string $controller A Controller string
-     *
      * @return callable A PHP callable
      */
-    protected function createController($controller)
+    protected function createController(string $controller)
     {
         if (false === strpos($controller, '::')) {
             return $this->instantiateController($controller);
@@ -124,11 +122,9 @@ protected function createController($controller)
     /**
      * Returns an instantiated controller.
      *
-     * @param string $class A class name
-     *
      * @return object
      */
-    protected function instantiateController($class)
+    protected function instantiateController(string $class)
     {
         return new $class();
     }

Controller/TraceableArgumentResolver.php

@@ -31,7 +31,7 @@ public function __construct(ArgumentResolverInterface $resolver, Stopwatch $stop
     /**
      * {@inheritdoc}
      */
-    public function getArguments(Request $request, $controller)
+    public function getArguments(Request $request, callable $controller)
     {
         $e = $this->stopwatch->start('controller.get_arguments');
 

DependencyInjection/LazyLoadingFragmentHandler.php

@@ -35,7 +35,7 @@ public function __construct(ContainerInterface $container, RequestStack $request
     /**
      * {@inheritdoc}
      */
-    public function render($uri, $renderer = 'inline', array $options = [])
+    public function render($uri, string $renderer = 'inline', array $options = [])
     {
         if (!isset($this->initialized[$renderer]) && $this->container->has($renderer)) {
             $this->addRenderer($this->container->get($renderer));