Expose all formaters as services #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
config-formatter
branch
from
733e6ee to
f801d98
Compare
Resources/config/monolog.xml
Outdated
Member
There was a problem hiding this comment.
I would vote for defining the class directly in the services instead of defining parameters for them
lyrixx
force-pushed
the
config-formatter
branch
from
f801d98 to
401ee75
Compare
Member
Author
|
@stof I addressed your comments |
lyrixx
changed the title
Member
|
Thank you @lyrixx. |
stof
added a commit
that referenced
this pull request
Oct 4, 2014
This PR was merged into the 2.6.x-dev branch.
Discussion
----------
Expose all formaters as services
Right now, it's not damn easy to configure a custom formatter
for an handler, because the developer should create a new service.
So, only for formatter that does not depend on external
configuration, we can use directly monolog formatter:
heka:
type: socket
connection_string: "%heka_endpoint%"
timeout: 1
connection_timeout: 1
formatter: monolog.formatter.json_formatter
Commits
-------
401ee75 Expose all formater as services
Member
Author
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it's not damn easy to configure a custom formatter
for an handler, because the developer should create a new service.
So, only for formatter that does not depend on external
configuration, we can use directly monolog formatter: