Skip to content

Conversation

@dquerioux
Copy link
Contributor

Add app_name option for New Relic handler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the XSD file too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.
It's done.

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use defaultNull() here for consistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be app-name

@stof
Copy link
Member

stof commented Feb 1, 2016

@dquerioux please update the PR to make it ready to be merged (I would like to do a release this evening)

@dquerioux
Copy link
Contributor Author

Thanks for the review @xabbuh ,
I updated the PR with your recomandations.

Is it good for you @stof ?

@Seldaek Seldaek merged commit 9b449c5 into symfony:master Mar 13, 2016
Seldaek added a commit that referenced this pull request Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants