Add timeout and conection timeout to logentries handler config definition #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dcsg
commented
Feb 24, 2016
dcsg
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Member
|
You need to add the new options to the XSD file too. |
| $handler['bubble'], | ||
| )); | ||
| if (isset($handler['timeout'])) { | ||
| $definition->addMethodCall('setTimeout', [$handler['timeout']]); |
Member
There was a problem hiding this comment.
The short array notation is not compatible with PHP 5.3.
Member
Author
|
@xabbuh they are not "new" since they are already defined for socket handler. But yes I don't see any timeout or connection_timeout in the .xsd file |
dcsg
force-pushed
the
add-timeout-and-connection-timeout-to-logentries
branch
from
51574e3 to
91c6ecb
Compare
Seldaek
added a commit
that referenced
this pull request
Mar 1, 2016
Member
|
Thanks, I added the missing stuff to xsd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.