Skip to content

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 18, 2013

@lyrixx
Copy link
Member Author

lyrixx commented Jul 18, 2013

This is not related to this pr but can I make a PR this this kinf of patche:

->validate()
    ->ifTrue(function($v) { return 'raven' === $v['type'] && !class_exists('Raven_Client'); })
    ->thenInvalid('please add "raven/raven" in your composer.json')
->end()

@Seldaek
Copy link
Member

Seldaek commented Jul 18, 2013

The class_exists stuff, I would rather do this sort of check in the Extension than in the Configuration class, but why not add it yes when creating a raven handler it would make sense.

Seldaek added a commit that referenced this pull request Jul 18, 2013
Allow raven.dsn with "null" value
@Seldaek Seldaek merged commit 6282f81 into symfony:master Jul 18, 2013
@lyrixx lyrixx deleted the patch-1 branch July 18, 2013 14:47
@lyrixx
Copy link
Member Author

lyrixx commented Jul 18, 2013

Thanks for the quick merge.

Can you tag a new release ?

About the class exist, could this be in monolog itself ?

@stof
Copy link
Member

stof commented Jul 18, 2013

Not really. Monolog expects receiving an instance, so it is too late if you don't have the class.

@lyrixx
Copy link
Member Author

lyrixx commented Jul 18, 2013

I should read the code before talk ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants