Skip to content

Conversation

@Spea
Copy link

@Spea Spea commented Apr 24, 2012

This PR adds support for the GelfHandler which was added in Monolog 1.1.0

stof added a commit that referenced this pull request Apr 25, 2012
Added support for the GelfHandler
@stof stof merged commit 120ef17 into symfony:master Apr 25, 2012
@Seldaek
Copy link
Member

Seldaek commented Apr 25, 2012

Shouldn't we auto-configure a publisher too if the php-gelf classes are available?

@Spea
Copy link
Author

Spea commented Apr 25, 2012

Maybe this is a good idea, yeah. I could make the publisher node a variable node so the handler can be configured like this:

monolog:
    handlers:
        gelf:
            type: gelf
            publisher:
                hostname: localhost # required
                port: 12201 # optional
                chunk_size: 1420 # optional
            level: DEBUG
            bubble: true

This will still work

monolog:
    handlers:
        gelf:
            type: gelf
            publisher: my.publisher.id
            level: DEBUG
            bubble: true

What do you think about this?

@Seldaek
Copy link
Member

Seldaek commented Apr 26, 2012

Sounds good to me, I just don't think we should force people to define services for simple usage, because that's quite a high barrier for many newcomers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants