Filter handler #81
Merged
Filter handler #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tests need to be added for this new config, which will also show you that you forgot to update the XSD for people using XML config files |
Contributor
Author
|
@stof Okay, I'll take care of that |
… schema for config, fixed level list interpretation
Contributor
Author
|
@stof How is it now? |
Member
There was a problem hiding this comment.
there is a missing fixXmlConfig() on the parent node to convert the XML tags to an array.
and I would rather name it accepted_levels (with the XML tag being accepted-level) than level_list. It is easier to understand IMO (and easier to convert to XML with a singular name when using a plural for the list)
Contributor
Author
|
@stof Okay, I think I've addressed all those issues now. |
Member
|
Looks good to me but I'll let @stof check one last time & merge if ok |
Contributor
Author
|
@xabbuh Okay, got it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.