removed test base class #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@fabpot Does it make sense to add a note to the upgrade guide? Just for the very rare case that someone used the class outside Symfony (this doesn't make make much sense but who knows). Since nothing forbids someone to do that. |
Member
Author
|
This is a purely internal class. As you said, using it outside of the context of our tests would not make sense. |
Member
|
Thanks @fabpot. |
stof
added a commit
that referenced
this pull request
Aug 31, 2014
This PR was merged into the 2.6.x-dev branch. Discussion ---------- removed test base class `TestCase` is an old class that was used in Symfony before Composer. Anyway, it was not used consistently used in the code and the error could never occurred as PHPUnit tries to load `vendor/autoload.php` first, which ensure that Monolog exists when running the tests. Commits ------- 9987326 removed test base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestCaseis an old class that was used in Symfony before Composer. Anyway, it was not used consistently used in the code and the error could never occurred as PHPUnit tries to loadvendor/autoload.phpfirst, which ensure that Monolog exists when running the tests.