Selenium #15
Selenium #15
Conversation
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Can you also add some (functional?) tests please?
| use Facebook\WebDriver\Remote\RemoteWebDriver; | ||
| use Facebook\WebDriver\WebDriver; | ||
| use \Facebook\WebDriver\WebDriverCapabilities; | ||
|
|
| use Facebook\WebDriver\Remote\DesiredCapabilities; | ||
| use Facebook\WebDriver\Remote\RemoteWebDriver; | ||
| use Facebook\WebDriver\WebDriver; | ||
| use \Facebook\WebDriver\WebDriverCapabilities; |
There was a problem hiding this comment.
The initial backslack must also be removed
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Looks good to me, but can you run PHP CS Fixer to fix the CS please?
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| /** | ||
| * @author Kévin Dunglas <dunglas@gmail.com> |
There was a problem hiding this comment.
There was a problem hiding this comment.
It defines the copyright, not the author! You can update this line safely, PHP CS Fixer will not complain.
|
ci passed |
| private $host; | ||
| private $capabilities; | ||
|
|
||
| public function __construct(?string $host = null, ?WebDriverCapabilities $capabilities = null) |
There was a problem hiding this comment.
Can be string $host = self::DEFAULT_HOST IIRC.
|
|
||
| final class SeleniumManager implements BrowserManagerInterface | ||
| { | ||
| private const DEFAULT_HOST = 'http://127.0.0.1:4444/wd/hub'; |
There was a problem hiding this comment.
I'm not even sure we need this constant, can be the default value in the constructor directly.
|
all fixed :) |
src/ProcessManager/ChromeManager.php
Outdated
| } | ||
|
|
||
| private function getDefaultArguments(): array | ||
| public function getDefaultArguments(): array |
There was a problem hiding this comment.
Why this change? If it is just for https://github.com/dunglas/panthere/pull/15/files#diff-0b7a157b54171e8b04337166e6da76d3R47, it is not worth it, just copy them.
|
Thank you very much @coraxster! You you mind updating the readme to explain how to use Selenium? |
|
Thank you for help :) |
* Selenium manager * Selenium manager create method * fix cs * simple test * fix selenium manager test * fix travis ci test, fix cs * fix cs * fix cs, refactor constructor * fix constructor * fix test
* Selenium manager * Selenium manager create method * fix cs * simple test * fix selenium manager test * fix travis ci test, fix cs * fix cs * fix cs, refactor constructor * fix constructor * fix test
2 participants
add support for selenium(also selenium grid)