Skip to content

Conversation

@OwlyCode
Copy link
Contributor

Hello,

I have a use case where my app is behind a security firewall that redirects anonymous users to Google's oauth page. In that case Panther fails to detect that the web server is up.

Here's a proposal to add a setting that allows custom path for readiness check. For instance you could do this :

$client = static::createPantherClient([
    'readinessPath' => '/ping'
]);

$client->getCookieJar()->set(new Cookie('jwt_token', $this->getTestToken()));
$client->request('GET', '/dashboard');
// [...]

And that would check http://127.0.0.1:48008/ping instead of http://127.0.0.1:48008/

@OwlyCode
Copy link
Contributor Author

OwlyCode commented Apr 5, 2019

Hello again, is there anything I can do to help integrating these changes ?

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dunglas dunglas merged commit a982e25 into symfony:master Jun 4, 2019
@dunglas
Copy link
Member

dunglas commented Jun 4, 2019

Thanks @OwlyCode

dunglas added a commit that referenced this pull request Dec 28, 2020
Added readinessPath to use custom path for server readiness detection
nicolas-grekas pushed a commit that referenced this pull request Jan 18, 2021
Added readinessPath to use custom path for server readiness detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants