Skip to content

Conversation

@pborreli
Copy link
Contributor

No description provided.

@webignition
Copy link

webignition commented Feb 28, 2020

Can you change the commit message to something more meaningful?

The commit message of "Fixed typo" won't provide much meaningful context when this is merged.

This change corrects the panther web server port number in the "Gitlab CI Integration" section of the readme.

A commit message that reflects this, perhaps "Correct Gitlab CI Integration panther port number", seems more appropriate.

@webignition
Copy link

I'm addition, it's generally considered good practice to first open an issue when finding a bug and then subsequently creating a PR to resolve the reported issue, with the PR description referencing the relevant issue (such as "Fixes #).

Doing so allows the issue to be de-coupled from the changes required to address the issue which presents a variety of benefits.

@dunglas dunglas merged commit 40ccacf into symfony:master Feb 28, 2020
@pborreli pborreli deleted the patch-1 branch February 28, 2020 14:16
@dunglas
Copy link
Member

dunglas commented Feb 28, 2020

Thanks @pborreli.

@webignition, thanks for helping maintaining the project. For such small changes not opening an issue is better IMHO, so we can just close or merge. An issue + a PR is two times more work for the maintainer.

dunglas added a commit that referenced this pull request Dec 28, 2020
nicolas-grekas pushed a commit that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants