Skip to content

Allow using an env var to determine chrome driver binary #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Allow using an env var to determine chrome driver binary #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8c868f
Allow using an env var to determine chrome driver binary
Pierstoval Jul 6, 2018
b2d85d4
Added small documentation to use the PANTHERE_CHROME_DRIVER_BINARY en…
Pierstoval Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ The following environment variables can be set to change some Panthère behavior
* `PANTHERE_NO_HEADLESS`: to disable browsers's headless mode (will display the testing window, useful to debug)
* `PANTHERE_NO_SANDBOX`: to disable [Chrome's sandboxing](https://chromium.googlesource.com/chromium/src/+/b4730a0c2773d8f6728946013eb812c6d3975bec/docs/design/sandbox.md) (unsafe, but allows to use Panthère in containers)
* `PANTHERE_WEB_SERVER_DIR`: to change the project's document root (default to `public/`)
* `PANTHERE_CHROME_DRIVER_BINARY`: to use another `chromedriver` binary, instead of relying on the ones already provided by Panthère

## Docker Integration

Expand Down
6 changes: 5 additions & 1 deletion src/ProcessManager/ChromeManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ final class ChromeManager implements BrowserManagerInterface

public function __construct(?string $chromeDriverBinary = null, ?array $arguments = null, array $options = [])
{
$this->process = new Process([$chromeDriverBinary ?? $this->findChromeDriverBinary()], null, null, null, null);
$this->process = new Process([$chromeDriverBinary ?: $this->findChromeDriverBinary()], null, null, null, null);
Copy link
Member

@dunglas dunglas Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@Pierstoval Pierstoval Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid $chromeDriverBinary be an empty string 😄

Copy link
Member

@dunglas dunglas Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be?

Copy link
Contributor Author

@Pierstoval Pierstoval Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a simple developer mistake, I know I might be paranoid, but if you think I should revert this, feel free to ask, and I will

Copy link
Member

@dunglas dunglas Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's ok! Can you just document this new env var in the README file please?

$this->arguments = $arguments ?? $this->getDefaultArguments();
$this->options = \array_merge($this->getDefaultOptions(), $options);
}
Expand Down Expand Up @@ -66,6 +66,10 @@ public function quit(): void

private function findChromeDriverBinary(): string
{
if ($binary = $_SERVER['PANTHERE_CHROME_DRIVER_BINARY'] ?? null) {
return $binary;
}

switch (PHP_OS_FAMILY) {
case 'Windows':
return __DIR__.'/../../chromedriver-bin/chromedriver.exe';
Expand Down