make the CI green again #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Still one failure :) |
dunglas
requested changes
Nov 21, 2025
| matrix: | ||
| php-versions: [ '8.1', '8.2', '8.3', '8.4'] | ||
| fail-fast: false | ||
| name: PHP ${{ matrix.php-versions }} (PHPUnit 11) Test on ubuntu-latest |
Member
There was a problem hiding this comment.
Suggested change
| name: PHP ${{ matrix.php-versions }} (PHPUnit 10) Test on ubuntu-latest |
But why must we downgrade?
Member
Author
There was a problem hiding this comment.
I guess the comment was misleading and PHPUnit 11 was never used (the job also is actually named phpunit-10).
dunglas
approved these changes
Nov 21, 2025
Member
Author
probably a flaky test :), on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.