[PHP80] Prevent redefinition of PHP 8.0 classes #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firtzberg
changed the title
Firtzberg
changed the title
|
ping |
As mentioned on a different issue from you, you shouldn't do that. Symfony ships classes that might require optional dependencies or a higher PHP version. Even if we apply your fix here, your script will continue to explode elsewhere. |
derrabus
approved these changes
Jun 24, 2021
nicolas-grekas
added a commit
that referenced
this pull request
Sep 13, 2021
…n related class stubs. (Firtzberg) This PR was merged into the 1.23-dev branch. Discussion ---------- [PHP 8.1] [PHP 7.3] Preventing redeclaration of PHP version related class stubs. Same as #359, only for other PHP version related class stubs. Commits ------- 4cddf20 Preventing redeclaration of PHP version related class stubs.
symfony-splitter
pushed a commit
to symfony/polyfill-php81
that referenced
this pull request
Sep 13, 2021
…n related class stubs. (Firtzberg) This PR was merged into the 1.23-dev branch. Discussion ---------- [PHP 8.1] [PHP 7.3] Preventing redeclaration of PHP version related class stubs. Same as symfony/polyfill#359, only for other PHP version related class stubs. Commits ------- 4cddf20 Preventing redeclaration of PHP version related class stubs.
|
Thank you @Firtzberg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not redeclaring polyfilled classes when PHP version is 8.0 or above.
The same approach is used for the Stringable interface in this commit.
One of my scripts runs
opcache_compile_fileon vendor files, including symfony. I'm in the process of upgrading to PHP 8. Runningopcache_compile_fileon either of the modified files causes a fatal errorFatal error: Cannot declare class ValueError/UnhandledMatchError, because the name is already in use.That's not the case on PHP versions below 8.