-
-
Notifications
You must be signed in to change notification settings - Fork 504
[UXIcons] Add recipe #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UXIcons] Add recipe #1477
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/ux-icons2.17 vs 2.19diff --git a/symfony/ux-icons/2.19/config/packages/ux_icons.yaml b/symfony/ux-icons/2.19/config/packages/ux_icons.yaml
new file mode 100644
index 00000000..aa5fe690
--- /dev/null
+++ b/symfony/ux-icons/2.19/config/packages/ux_icons.yaml
@@ -0,0 +1,20 @@
+# Full configuration reference: https://symfony.com/bundles/ux-icons/current/index.html#configuration
+ux_icons:
+
+ # Default HTML attributes to add to all icons
+ default_icon_attributes:
+
+ # Use current text color to fill the icon
+ fill: currentColor
+
+ # Default dimensions
+ height: '1em'
+ width: '1em'
+
+ # Throw an exception if an icon is not
+ ignore_not_found: false
+
+when@prod:
+ ux_icons:
+ # Suppress exceptions for missing icons in production
+ ignore_not_found: true
diff --git a/symfony/ux-icons/2.17/manifest.json b/symfony/ux-icons/2.19/manifest.json
index 60cabefb..c2667820 100644
--- a/symfony/ux-icons/2.17/manifest.json
+++ b/symfony/ux-icons/2.19/manifest.json
@@ -3,6 +3,7 @@
"Symfony\\UX\\Icons\\UXIconsBundle": ["all"]
},
"copy-from-recipe": {
- "assets/": "assets/"
+ "assets/": "assets/",
+ "config/": "%CONFIG_DIR%/"
}
} |
Head branch was pushed to by a user without write access
|
I would maybe have used when@dev .. if we plan to set ignore true per default in 3.0 |
Head branch was pushed to by a user without write access
That's fine with me, but let's do that with the recipe for 3.0? :) |
Related to symfony/ux#3146 and symfony/ux#3172, cc @smnandre @tacman @Zales0123