Skip to content

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Nov 15, 2025

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

Related to symfony/ux#3146 and symfony/ux#3172, cc @smnandre @tacman @Zales0123

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 15, 2025 15:04
@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1477/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1477/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'symfony/ux-icons:^2.19'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/ux-icons

2.17 vs 2.19
diff --git a/symfony/ux-icons/2.19/config/packages/ux_icons.yaml b/symfony/ux-icons/2.19/config/packages/ux_icons.yaml
new file mode 100644
index 00000000..aa5fe690
--- /dev/null
+++ b/symfony/ux-icons/2.19/config/packages/ux_icons.yaml
@@ -0,0 +1,20 @@
+# Full configuration reference: https://symfony.com/bundles/ux-icons/current/index.html#configuration
+ux_icons:
+
+    # Default HTML attributes to add to all icons
+    default_icon_attributes:
+
+        # Use current text color to fill the icon
+        fill: currentColor
+
+        # Default dimensions
+        height: '1em'
+        width: '1em'
+
+    # Throw an exception if an icon is not
+    ignore_not_found: false
+
+when@prod:
+    ux_icons:
+        # Suppress exceptions for missing icons in production
+        ignore_not_found: true
diff --git a/symfony/ux-icons/2.17/manifest.json b/symfony/ux-icons/2.19/manifest.json
index 60cabefb..c2667820 100644
--- a/symfony/ux-icons/2.17/manifest.json
+++ b/symfony/ux-icons/2.19/manifest.json
@@ -3,6 +3,7 @@
         "Symfony\\UX\\Icons\\UXIconsBundle": ["all"]
     },
     "copy-from-recipe": {
-        "assets/": "assets/"
+        "assets/": "assets/",
+        "config/": "%CONFIG_DIR%/"
     }
 }

auto-merge was automatically disabled November 15, 2025 15:04

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 15, 2025 15:04
@smnandre
Copy link
Member

I would maybe have used when@dev .. if we plan to set ignore true per default in 3.0

auto-merge was automatically disabled November 15, 2025 19:58

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 15, 2025 19:58
@Kocal
Copy link
Member Author

Kocal commented Nov 15, 2025

I would maybe have used when@dev .. if we plan to set ignore true per default in 3.0

That's fine with me, but let's do that with the recipe for 3.0? :)

@fabpot fabpot disabled auto-merge November 16, 2025 08:20
@fabpot fabpot merged commit 8a33963 into symfony:main Nov 16, 2025
2 checks passed
@Kocal Kocal deleted the ux-icons branch November 16, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants