Fix Entry serialization #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! This has taken very long and it seems like this bug is now fixed (either due to a fix in newer PHP versions or by changing to the new PHP serialization feature (ref #90)). I've used a test case from another PR to make sure we don't reintroduce this bug somehow: #94 Fyi, I'll try to take care of ACL as a low-maintenance package. This means that I won't make any features or bug fixes myself, but I'm happy to support the community by merging and releasing contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that it is not BC breaks. Also as for people who extends from FieldEntry for example and will be use unserialize bug will be not fixed. But I don't see better solution for this bug.
If it is BC break, than better drop legacy support at all.