Skip to content

Commit a71a0cb

Browse files
committed
minor #21530 [Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory (nicuserban)
This PR was merged into the 7.3 branch. Discussion ---------- [Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory In this PR https://github.com/symfony/symfony-docs/pull/21507/files , when pointing out that constructor property promotion should not be used when injecting `$lockFactory`, I also wrongly introduced a `parent::__construct()` call. As in the current example attribute is used and the example command class is no longer extending `Symfony\Component\Console\Command\Command`, the call to the constructor of the parent class is actually wrong. I just wanted to fix this and to apologize for any inconvenience I caused with the back-and-forth related to this issue. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `7.x` for features of unreleased versions). --> Commits ------- 2f91e30 [Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory
2 parents f9c60f4 + 2f91e30 commit a71a0cb

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

console/lockable_trait.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ a ``$lockFactory`` property with your own lock factory::
6060
public function __construct(LockFactory $lockFactory)
6161
{
6262
$this->lockFactory = $lockFactory;
63-
64-
parent::__construct();
6563
}
6664

6765
// ...

0 commit comments

Comments
 (0)