Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed route examples #11085

Closed
wants to merge 2 commits into
base: 4.2
from

Conversation

@HeahDude
Copy link
Member

HeahDude commented Mar 5, 2019

Fixes partially #8462 and #10762.

@HeahDude HeahDude added the Routing label Mar 5, 2019

@HeahDude HeahDude added this to the 4.2 milestone Mar 5, 2019

@HeahDude HeahDude self-assigned this Mar 5, 2019

@HeahDude HeahDude requested a review from javiereguiluz Mar 5, 2019

@HeahDude HeahDude changed the base branch from master to 4.2 Mar 5, 2019

@HeahDude HeahDude force-pushed the HeahDude:fix-xml-routes branch 5 times, most recently from c8bff60 to d73e48a Mar 5, 2019

Show resolved Hide resolved components/routing.rst Outdated

@HeahDude HeahDude force-pushed the HeahDude:fix-xml-routes branch from d73e48a to 34033db Mar 5, 2019

@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Mar 5, 2019

Thanks a lot Jules! This is a massive contribution and a great improvement!!

@HeahDude

This comment has been minimized.

Copy link
Member Author

HeahDude commented Mar 5, 2019

Thank you for merging already!

@HeahDude HeahDude deleted the HeahDude:fix-xml-routes branch Mar 5, 2019

HeahDude pushed a commit to HeahDude/symfony-docs that referenced this pull request Mar 5, 2019

HeahDude pushed a commit to HeahDude/symfony-docs that referenced this pull request Mar 5, 2019

HeahDude pushed a commit to HeahDude/symfony-docs that referenced this pull request Mar 5, 2019

javiereguiluz added a commit that referenced this pull request Mar 6, 2019

minor #11089 Some route fixes left after #11085 (Jules Pietri)
This PR was merged into the 4.2 branch.

Discussion
----------

Some route fixes left after #11085

Round 2 :).

Commits
-------

802244d Some route fixes left after #11085

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 6, 2019

Merge branch '4.2'
* 4.2:
  Some route fixes left after symfony#11085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.