Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomCrawler] Document UriResolver #13054

Merged
merged 1 commit into from Feb 11, 2020
Merged

[DomCrawler] Document UriResolver #13054

merged 1 commit into from Feb 11, 2020

Conversation

@lyrixx
Copy link
Member

lyrixx commented Feb 5, 2020

fixes #13040

@lyrixx lyrixx force-pushed the lyrixx:dom-api branch from f172a93 to d3f0ed5 Feb 5, 2020
@OskarStark OskarStark added this to the 5.1 milestone Feb 5, 2020
Copy link
Contributor

OskarStark left a comment

Thank you Greg, can you please add a sentence when and why could this be useful?

components/dom_crawler.rst Outdated Show resolved Hide resolved
components/dom_crawler.rst Outdated Show resolved Hide resolved
components/dom_crawler.rst Outdated Show resolved Hide resolved
@lyrixx

This comment was marked as resolved.

Copy link
Member Author

lyrixx commented Feb 5, 2020

Thank you Greg, can you please add a sentence when and why could this be useful?

Sure. But I really don't know expect for very specific usage. Like a web crawler.
WDYT?

@lyrixx lyrixx force-pushed the lyrixx:dom-api branch from 3330fd5 to 424cd99 Feb 10, 2020
@lyrixx lyrixx requested review from OskarStark and javiereguiluz Feb 10, 2020
@lyrixx lyrixx changed the title [DomCrawler] Document UriExpander [DomCrawler] Document UriResolver Feb 10, 2020
@lyrixx lyrixx force-pushed the lyrixx:dom-api branch from 424cd99 to e278e13 Feb 10, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Feb 11, 2020
…rixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DomCrawler] Rename UriExpander.php -> UriResolver

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | refs symfony/symfony-docs#13054 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#13054 // don't open a new issue in doc repo

Commits
-------

3217f81 [DomCrawler] Rename UriExpander.php -> UriResolver
Copy link
Contributor

OskarStark left a comment

Thank you, some minor comments

components/dom_crawler.rst Show resolved Hide resolved
components/dom_crawler.rst Show resolved Hide resolved
components/dom_crawler.rst Show resolved Hide resolved
@OskarStark OskarStark self-assigned this Feb 11, 2020
@OskarStark OskarStark force-pushed the lyrixx:dom-api branch from e278e13 to 4ce42c9 Feb 11, 2020
@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Feb 11, 2020

Thank you, I made the changes while merging in 905d1fc! 🎉

@OskarStark OskarStark merged commit 4ce42c9 into symfony:master Feb 11, 2020
2 checks passed
2 checks passed
Build
Details
DOCtor-RST
Details
OskarStark added a commit that referenced this pull request Feb 11, 2020
@lyrixx lyrixx deleted the lyrixx:dom-api branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.