-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add documentation for the new BinaryFileResponse class (#1866) #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbafford
commented
Mar 30, 2013
Q | A |
---|---|
Doc fix? | yes |
New docs? | yes (symfony/symfony#4546) |
Applies to | 2.2 |
Fixed tickets | #1866 |
There is also a special :class:`Symfony\\Component\\HttpFoundation\\JsonResponse` | ||
class that helps return JSON responses. See :ref:`component-http-foundation-json-response`. | ||
There are also special classes to make certain kinds of responses easier: | ||
- For JSON, there is :class:`Symfony\\Component\\HttpFoundation\\JsonResponse`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an empty line before this one
|
||
- For JSON, there is :class:`Symfony\\Component\\HttpFoundation\\JsonResponse`. | ||
See :ref:`component-http-foundation-json-response`. | ||
- For files, there is :class:`Symfony\\Component\\HttpFoundation\\JsonResponse`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little typo here: I think you meant Symfony\\Component\\HttpFoundation\\BinaryFileResponse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct. I have that fixed now.
Add documentation for the new BinaryFileResponse class (#1866)
Hey John! This is really great - and I get to learn about a new feature from your work ;). I've only made a few small changes and also mentioned Thanks! |
Glad to be of help! :) |