load() method definition from ExtensionInterface

[mmarchois]

The load method definition seems to be wrong. In the Symfony\Component\DependencyInjection\ContainerBuilder\ExtensionInterface, the method definition is public function load(array $config, ContainerBuilder $container);

[ogizanagi]

I wonder if we shouldn't fix the ExtensionInterface::load signature instead.

Every extensions defined in Symfony's bundles for instance (but you can check other ones, as well as third party bundles) are using $configs. And actually that makes a lot of sense, as $configs is an array of extension configs, not already merged, on contrary of the processed configuration you usually get by:

$config = $this->processConfiguration(new Configuration(), $configs);

In other words, for the framework extension, you can actually get something like this value for $configs:

array:2 [▼
  0 => array:13 [▼
    "translator" => array:1 [▶]
    "secret" => "ThisTokenIsNotSoSecretChangeIt"
    "router" => array:2 [▼
      "resource" => "[..]/app/config/routing.yml"
      "strict_requirements" => null
    ]
    "form" => null
    "csrf_protection" => null
    "validation" => array:1 [▶]
    // [...]
  ]
  1 => array:2 [▼
    "router" => array:2 [▼
      "resource" => "[..]/app/config/routing_dev.yml"
      "strict_requirements" => true
    ]
    "profiler" => array:1 [▼
      "only_exceptions" => false
    ]
  ]
]

because the framework extension key is used many (2) times: in app/config/config.yml and app/config/config_dev.yml. The values are not merged yet. This is the task of the symfony/config component.

[wouterj]

I think we explicitely renamed it to $configs to better cover the value of this parameter: A list of the configuration (which has yet to be merged/processed into a single config).

So I'm going to close this one and I recommend you open a PR/issue on the code repository to rename the parameter instead. If you don't agree, feel free to leave a comment!