Use <button> instead of <a> for JavaScript interactive buttons #9892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to call `preventDefault()` to disable the default action of <a> elements, since <button type="button"> has no default action whatsoever.
|
@Calinou this looks really nice to me! Thank you. I'll give some time before merging so others can review and comment on this. |
20uf
approved these changes
Jun 10, 2018
|
Thanks Hugo. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2018
…ttons (Calinou) This PR was merged into the 2.8 branch. Discussion ---------- Use <button> instead of <a> for JavaScript interactive buttons This removes the need to call `preventDefault()` to disable the default action of `<a>` elements, since `<button type="button">` has no default action whatsoever. See also [this Stack Overflow question](https://stackoverflow.com/questions/469059/button-vs-input-type-button-which-to-use) about the `<button>` HTML tag. Commits ------- 87db1b6 Use <button> instead of <a> for JavaScript interactive buttons
apfelbox
reviewed
Jun 11, 2018
| @@ -353,8 +353,8 @@ will be show next): | |||
| var $collectionHolder; | |||
|
|
|||
| // setup an "add a tag" link | |||
| var $addTagLink = $('<a href="#" class="add_tag_link">Add a tag</a>'); | |||
| var $newLinkLi = $('<li></li>').append($addTagLink); | |||
| var $addTagButton = $('<button type="button" class="add_tag_link">Add a tag</a>'); | |||
There was a problem hiding this comment.
The closing tag should be updated as well: <button>...</a>
apfelbox
reviewed
Jun 11, 2018
| $removeFormA.on('click', function(e) { | ||
| // prevent the link from creating a "#" on the URL | ||
| e.preventDefault(); | ||
| var $removeFormButton = $('<button type="button">Delete this tag</a>'); |
|
Both inline comments adressed in #9911 |
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to call
preventDefault()to disable the default action of<a>elements, since<button type="button">has no default action whatsoever.See also this Stack Overflow question about the
<button>HTML tag.