[EventDispatcher] Fixed #12845 adding a listener to an event that is currently being dispatched #12848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spatched will not result into a fatal error in TraceableEventDispatcher [EventDispatcher]
pjordaan
changed the title
pjordaan
changed the title
|
Thank you @pjordaan. |
fabpot
added a commit
that referenced
this pull request
Dec 12, 2014
…nt that is currently being dispatched (Pieter Jordaan) This PR was merged into the 2.5 branch. Discussion ---------- [EventDispatcher] Fixed #12845 adding a listener to an event that is currently being dispatched [EventDispatcher] Fixed adding listener when event is currently being dispatched | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12845 | License | MIT Commits ------- 0cbc2b0 Fixed #12845 adding a listener to an event that is currently being dispatched will not result into a fatal error in TraceableEventDispatcher [EventDispatcher]
|
What about 2.6 branch? This branch have the same problems |
|
@shustrik Older branches are regularly merged into newer branches which means that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EventDispatcher] Fixed adding listener when event is currently being dispatched