add a limit and a test to FlattenExceptionTest. #13004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dawehner
commented
Dec 16, 2014
dawehner
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13003 |
| License | MIT |
| Doc PR |
There was a problem hiding this comment.
The & is not needed here, is it?
There was a problem hiding this comment.
Well, it is ... otherwise you don't count the total items, but just the amount of items in your current recursion chain.
[
[1, 2, 3]
[1, 2, 3]
[1, 2, 3]
]
In this example $count would result in a maximum number of 6, but it should be 9
|
👍 |
There was a problem hiding this comment.
Why has CS checker left out variable name with underscore?
|
Thank you @dawehner. |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2014
…hner) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #13004). Discussion ---------- add a limit and a test to FlattenExceptionTest. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13003 | License | MIT | Doc PR | Commits ------- c6bcf05 add a limit and a test to FlattenExceptionTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.