Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Ensure class declarations are loaded only once #16651

Merged
merged 1 commit into from Nov 24, 2015

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 24, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #15297
License MIT
Doc PR -
@TomasVotruba

This comment has been minimized.

Copy link
Contributor

TomasVotruba commented Nov 24, 2015

👍

@stof

This comment has been minimized.

Copy link
Member

stof commented Nov 24, 2015

👍

Composer avoids that to avoid the stat calls on each class loading, but it is indeed a good idea to do this in the DebugClassLoader

@nicolas-grekas nicolas-grekas merged commit 01c08fc into symfony:2.7 Nov 24, 2015

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 24, 2015

bug #16651 [Debug] Ensure class declarations are loaded only once (ni…
…colas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Debug] Ensure class declarations are loaded only once

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15297
| License       | MIT
| Doc PR        | -

Commits
-------

01c08fc [Debug] Ensure class declarations are loaded only once

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:debug-once branch Nov 24, 2015

@weaverryan

This comment has been minimized.

Copy link
Member

weaverryan commented Nov 24, 2015

Wow, nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.