Fixed form data collector #20707
Closed
Fixed form data collector #20707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Padam87
commented
Nov 30, 2016
•
Padam87
commented
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20698 |
| License | MIT |
| Doc PR | - |
|
Would be nice to provide a test case. |
|
After spending some time trying to write tests, I'm more baffled than before :) This should work, and the tests I wrote confirm that. Both mocked and functional tests passed with the original code. Yet on a real, actual form, the children properties are not getting replaced, almost like if the references weren't working. (forms_by_hash is replaced, forms is replaced, forms.form.children is not) The only remaining clue I have is the form being created via a subrequest. If it is created in the main request, everything is okay. |
|
I checked out the patch and have a reproducer so I'm going to try to understand a bit better how this fails now :) |
|
Closing in favor of #20762 |
fabpot
added a commit
that referenced
this pull request
Dec 6, 2016
This PR was merged into the 3.2 branch. Discussion ---------- [Form] Fix FormDataCollector | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20698 | License | MIT | Doc PR | - Alternative to #20707 Commits ------- 50400c4 [Form] Add failing test for data collector bug 164a20c [Form] Fix FormDataCollector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.