Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] deprecate some router options #30249

Merged
merged 1 commit into from Feb 21, 2019

Conversation

@Tobion
Copy link
Member

Tobion commented Feb 14, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #28865 (comment)
License MIT
Doc PR symfony/symfony-docs#...

@Tobion Tobion force-pushed the Tobion:deprecate-routing-options branch from 50bb1f2 to 9ad7aaf Feb 14, 2019

@Tobion Tobion force-pushed the Tobion:deprecate-routing-options branch from 9ad7aaf to 763738c Feb 14, 2019

@Tobion

This comment has been minimized.

Copy link
Member Author

Tobion commented Feb 15, 2019

For some reason the non-insulted functional tests are failing.

@fabpot

fabpot approved these changes Feb 15, 2019

@Tobion Tobion force-pushed the Tobion:deprecate-routing-options branch from 763738c to a4e592f Feb 15, 2019

@Tobion Tobion force-pushed the Tobion:deprecate-routing-options branch from a4e592f to bf4cd61 Feb 15, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 16, 2019

@stof

stof approved these changes Feb 18, 2019

@xabbuh

xabbuh approved these changes Feb 18, 2019

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Feb 18, 2019

we should document this in UPGRADE-4.3.md and UPGRADE-5.0.md too though

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 21, 2019

Thank you @Tobion.

@fabpot fabpot merged commit bf4cd61 into symfony:master Feb 21, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 21, 2019

feature #30249 [Routing] deprecate some router options (Tobion)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Routing] deprecate some router options

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28865 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

bf4cd61 [Routing] deprecate some router options

@Tobion Tobion deleted the Tobion:deprecate-routing-options branch Feb 22, 2019

fabpot added a commit that referenced this pull request Mar 3, 2019

minor #30387 add deprecated router options to upgrade files (xabbuh)
This PR was merged into the 4.3-dev branch.

Discussion
----------

add deprecated router options to upgrade files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30249 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

c3da27a add deprecated router options to upgrade files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.