Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix command testing with missing user inputs #30271

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

chalasr commented Feb 16, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30138
License MIT
Doc PR n/a

Fixes the remaining cases where test execution hangs using CommandTester.

@chalasr chalasr added this to the 3.4 milestone Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch from 7676bf1 to 89a8b0e Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch from 89a8b0e to 11136dd Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch from 11136dd to 85feb82 Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch from 85feb82 to dcdd68f Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch 6 times, most recently from 281116e to 13c767b Feb 16, 2019

@chalasr chalasr force-pushed the chalasr:cli-testing-empty-input-stream branch from 13c767b to ac4e9b0 Feb 18, 2019

@chalasr chalasr merged commit ac4e9b0 into symfony:3.4 Feb 19, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request Feb 19, 2019

bug #30271 [Console] Fix command testing with missing user inputs (ch…
…alasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix command testing with missing user inputs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30138
| License       | MIT
| Doc PR        | n/a

Fixes the remaining cases where test execution hangs using `CommandTester`.

Commits
-------

ac4e9b0 [Console] Fix command testing with missing inputs

@chalasr chalasr deleted the chalasr:cli-testing-empty-input-stream branch Feb 19, 2019

This was referenced Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.