[HttpKernel] Auto-register kernel as an extension #38243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
changed the title
HypeMC
changed the title
fabpot
approved these changes
Sep 24, 2020
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony already supports having the kernel as an extension. This is evident by the fact that the
config:dump-referenceanddebug:configcommands check whether the kernel implements theExtensionInterface. Nonetheless, it's still required to register the kernel manually as an extension.With this PR the kernel will be automatically registered as an extension if it implements the
ExtensionInterface. This is the same logic as when the kernel implements theCompilerPassInterface.