[Icons] Icon changes
#1665
Merged
[Icons] Icon changes
#1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
Mar 27, 2024
Comment on lines
-196
to
-205
| public function serialize(): string | ||
| { | ||
| return serialize([$this->innerSvg, $this->attributes]); | ||
| } | ||
|
|
||
| public function unserialize(string $data): void | ||
| { | ||
| [$this->innerSvg, $this->attributes] = unserialize($data); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Those methods were here for caching purposes no?
Member
Author
There was a problem hiding this comment.
yes, but this is handled by __serialize/__unserialize IIUC.
Member
Author
There was a problem hiding this comment.
It's my understanding that the Serializable interface is being phased out.
Member
Yes, but we will see when it happens. 100% support on this move right now. |
smnandre
approved these changes
Mar 30, 2024
carsonbot
added
Status: Reviewed
kbond
force-pushed
the
icon/remove-serializable
branch
from
a49ad9f to
b8930e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializablefromIcon(this isn't needed unless I'm mistaken)Iconup a level (this is a personal preference). @smnandre did you have plans for more classes in theSvgnamespace?