-
-
Couldn't load subscription status.
- Fork 388
[LiveComponent] Add dispatch browser event assertion in InteractsWithLiveComponents #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Add dispatch browser event assertion in InteractsWithLiveComponents #3136
Conversation
cba34d0 to
ab52681
Compare
|
I'm asking myself if it's better to create a dedicated component that only have one action that dispatch browser event rather than reuse |
|
Nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Except for the naming, it's good. Could you add an entry for 2.31 in the LiveComponent CHANGELOG.md?
Thanks
ab52681 to
b4618e8
Compare
b4618e8 to
a345d81
Compare
a345d81 to
5943c89
Compare
|
@Kocal I fixed my PR following your review but I have one test that fail and I don't understand why. Do you have any idea ? |
|
Thanks! The issue comes from Foundry, it has been reported in zenstruck/foundry#1011 (comment) and zenstruck/foundry#1012 |
|
Thank you @Develog. |
Next to this PR #2712 I wanted to add test assertion on dispatchBrowserEvent and not only on emited event.
I reuse same logic as the
ComponentWithEmit.php.$this->assertComponentNotDispatchEvent($testComponent->render(), 'otherBrowserEvent');