Skip to content

[Toolkit][Shadcn] Add Spinner component - #3145

Merged
Kocal merged 1 commit into
symfony:2.xfrom
bernard-ng:bernard-ng/toolkit-shadcn-spinner
Oct 21, 2025
Merged

Kocal merged 1 commit into
symfony:2.xfrom
bernard-ng:bernard-ng/toolkit-shadcn-spinner

Conversation

@bernard-ng

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
License MIT

Add Spinner component, An indicator that can be used to show a loading state.
refs: https://ui.shadcn.com/docs/components/spinner

@bernard-ng
bernard-ng requested a review from Kocal as a code owner October 17, 2025 20:30
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Feature New Feature Toolkit labels Oct 17, 2025
@Kocal

Kocal commented Oct 21, 2025

Copy link
Copy Markdown
Member

Thanks for the contribution, that's much appreciated!

I've pushed on your PR some modifications:

  • it was not possible to use <twig:Spinner class="...">, the class attribute was fully overridden by {{ ...attributes }} (looks like the ComponentAttributes::getIterator() does not handle ComponentAttributes::$rendered property, like ComponentAttributes::__toString()) and so the Spinner was not rotating anymore. Using {{ ...attributes.without('class') }} fixed the issue
  • I added some examples with size and color

@Kocal

Kocal commented Oct 21, 2025

Copy link
Copy Markdown
Member

Thank you @bernard-ng.

@Kocal
Kocal merged commit 15db9e6 into symfony:2.x Oct 21, 2025
18 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Status: Needs Review Needs to be reviewed Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants