Skip to content

Conversation

@andyexeter
Copy link

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? yes
Issues Fix #1998
License MIT

This pull request introduces support for using index.html.twig as a component template when the component is placed in a directory named after itself. This helps avoid repetition and improves organization for nested components. The documentation is updated to explain this feature, and corresponding logic and tests are added to ensure correct template resolution.

@carsonbot carsonbot added Documentation Improvements or additions to documentation Feature New Feature Status: Needs Review Needs to be reviewed labels Nov 14, 2025
@carsonbot carsonbot changed the title Allow using directory name as component name for anonymous components Allow using directory name as component name for anonymous components Nov 14, 2025
@andyexeter andyexeter changed the title Allow using directory name as component name for anonymous components [TwigComponent] Allow using directory name as component name for anonymous components Nov 14, 2025
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Nice PR thank you! Made some minor comments on the docs... could you maybe add one integration test, just to be sure everything is working correctly and prevent future regression?

@smnandre smnandre removed the Status: Needs Review Needs to be reviewed label Nov 15, 2025
@carsonbot carsonbot changed the title [TwigComponent] Allow using directory name as component name for anonymous components Allow using directory name as component name for anonymous components Nov 15, 2025
@carsonbot carsonbot changed the title Allow using directory name as component name for anonymous components [TwigComponent] Allow using directory name as component name for anonymous components Nov 15, 2025
@andyexeter
Copy link
Author

@smnandre thanks for the review. Integration test added and suggestions implemented.

@andyexeter andyexeter force-pushed the 1998-anonymous-name-resolution-fallback branch from 19a09d5 to 549d547 Compare November 16, 2025 16:40
@smnandre
Copy link
Member

Note: fabbot fails are false-positive and can be ignored (nothing to do here)

@carsonbot carsonbot added the Status: Reviewed Has been reviewed by a maintainer label Nov 17, 2025
@Kocal
Copy link
Member

Kocal commented Nov 17, 2025

A small rebase would be awesome, some jobs should become green :)

@andyexeter andyexeter force-pushed the 1998-anonymous-name-resolution-fallback branch from f36ab59 to 9f56128 Compare November 17, 2025 17:01
@andyexeter
Copy link
Author

@Kocal rebased :) Still a few failing checks but these appear unrelated.

@Kocal
Copy link
Member

Kocal commented Nov 17, 2025

You can ignore the failing checks, that's fine.

There is just a missing CHANGELOG entry and that would be perfect!

Thanks

@andyexeter
Copy link
Author

What version heading should this change go under?

@andyexeter andyexeter force-pushed the 1998-anonymous-name-resolution-fallback branch from 9f56128 to 7b0f600 Compare November 19, 2025 17:03
@andyexeter
Copy link
Author

@Kocal I've added a line under 2.32 in CHANGELOG, hopefully this is ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Feature New Feature Status: Reviewed Has been reviewed by a maintainer TwigComponent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Anonymous Name Resolution Fallback

4 participants