-
-
Notifications
You must be signed in to change notification settings - Fork 394
[TwigComponent] Allow using directory name as component name for anonymous components #3169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
[TwigComponent] Allow using directory name as component name for anonymous components #3169
Conversation
smnandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Nice PR thank you! Made some minor comments on the docs... could you maybe add one integration test, just to be sure everything is working correctly and prevent future regression?
|
@smnandre thanks for the review. Integration test added and suggestions implemented. |
19a09d5 to
549d547
Compare
|
Note: fabbot fails are false-positive and can be ignored (nothing to do here) |
|
A small rebase would be awesome, some jobs should become green :) |
f36ab59 to
9f56128
Compare
|
@Kocal rebased :) Still a few failing checks but these appear unrelated. |
|
You can ignore the failing checks, that's fine. There is just a missing CHANGELOG entry and that would be perfect! Thanks |
|
What version heading should this change go under? |
9f56128 to
7b0f600
Compare
|
@Kocal I've added a line under 2.32 in CHANGELOG, hopefully this is ok :) |
This pull request introduces support for using
index.html.twigas a component template when the component is placed in a directory named after itself. This helps avoid repetition and improves organization for nested components. The documentation is updated to explain this feature, and corresponding logic and tests are added to ensure correct template resolution.