[Translator] Early exit parameters extraction from Intl messages, if no { is found
#3219
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
translator-perf-intl-params-extractor
branch
from
0559857 to
c8a303c
Compare
Member
Author
|
Not sure if this must be considered as a bug or feature 🤔 |
There was a problem hiding this comment.
Pull request overview
This PR introduces a performance optimization to the IntlMessageParametersExtractor by adding an early exit when messages don't contain ICU parameter syntax. The optimization skips expensive parsing for the ~86% of messages that don't use ICU MessageFormat parameters (indicated by the absence of {), resulting in a ~60% reduction in cache-clear time.
- Early return added to avoid parsing messages without parameters
- Optimization based on the fact that all ICU MessageFormat parameters use
{as the opening delimiter - No functional changes - only performance improvement
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3218
On an app with ~3320 keys, ~2870 of them didn't use the ICU syntax. Early exiting when no
{reduced the cache-clear time by ~60%: