Skip to content

Commit 138777a

Browse files
committed
minor symfony#61409 [Security] Add bool return type to CustomCredentials callable parameter (Nico Hiort af Ornäs)
This PR was merged into the 7.3 branch. Discussion ---------- [Security] Add bool return type to CustomCredentials callable parameter | Q | A | ------------- | --- | Branch? | 7.3 for bug fixes | Bug fix? | yes | New feature? | no <!-- if yes, also update src/**/CHANGELOG.md --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fixes comment in [symfony#60245](symfony#60245 (comment)) | License | MIT <!-- 🛠️ Replace this text with a concise explanation of your change: - What it does and why it's needed - A simple example of how it works (include PHP, YAML, etc.) - If it modifies existing behavior, include a before/after comparison Contributor guidelines: - ✅ Add tests and ensure they pass - 🐞 Bug fixes must target the **lowest maintained** branch where they apply https://symfony.com/releases#maintained-symfony-branches - ✨ New features and deprecations must target the **feature** branch and must add an entry to the changelog file of the patched component: https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - 🔒 Do not break backward compatibility: https://symfony.com/bc --> Commits ------- cf02add Add bool return type to CustomCredentials callable parameter
2 parents dff83bc + cf02add commit 138777a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Symfony/Component/Security/Http/Authenticator/Passport/Credentials/CustomCredentials.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ class CustomCredentials implements CredentialsInterface
2727
private bool $resolved = false;
2828

2929
/**
30-
* @param callable(mixed, UserInterface) $customCredentialsChecker If the callable does not return `true`, a
31-
* BadCredentialsException is thrown. You may
32-
* also throw a more specific exception.
30+
* @param callable(mixed, UserInterface): bool $customCredentialsChecker If the callable does not return `true`, a
31+
* BadCredentialsException is thrown. You may
32+
* also throw a more specific exception.
3333
*/
3434
public function __construct(
3535
callable $customCredentialsChecker,

0 commit comments

Comments
 (0)