bug symfony#60423 [DependencyInjection] Make DefinitionErrorExceptionPass consider IGNORE_ON_UNINITIALIZED_REFERENCE and RUNTIME_EXCEPTION_ON_INVALID_REFERENCE the same (MatTheCat)

This PR was merged into the 6.4 branch.

Discussion
----------

[DependencyInjection] Make `DefinitionErrorExceptionPass` consider `IGNORE_ON_UNINITIALIZED_REFERENCE` and `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE` the same

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#54570
| License       | MIT

The test container can make runtime errors appear at compile-time: say you have a private definition referenced by a controller. Such a reference would be configured with `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE`, so if the private definition references an errored one, you’d get no exception at compile-time.

Now, if this private definition is also referenced by the test container, it would be as `IGNORE_ON_UNINITIALIZED_REFERENCE`. This would change `DefinitionErrorExceptionPass::isErrorForRuntime()` result and trigger a compile-time exception.

Following symfony#60423 (comment), this PR makes the `DefinitionErrorExceptionPass` consider `IGNORE_ON_UNINITIALIZED_REFERENCE` the same way than `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE` to fix this issue.

Commits
-------

72171c0 [DependencyInjection] Make `DefinitionErrorExceptionPass` consider `IGNORE_ON_UNINITIALIZED_REFERENCE` and `RUNTIME_EXCEPTION_ON_INVALID_REFERENCE` the same

Author: fabpot

src/Symfony/Component/DependencyInjection/Compiler/DefinitionErrorExceptionPass.php

@@ -65,7 +65,10 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
         }
 
         if ($value instanceof Reference && $this->currentId !== $targetId = (string) $value) {
-            if (ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE === $value->getInvalidBehavior()) {
+            if (
+                ContainerInterface::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE === $value->getInvalidBehavior()
+                || ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE === $value->getInvalidBehavior()
+            ) {
                 $this->sourceReferences[$targetId][$this->currentId] ??= true;
             } else {
                 $this->sourceReferences[$targetId][$this->currentId] = false;

src/Symfony/Component/DependencyInjection/Tests/Compiler/DefinitionErrorExceptionPassTest.php

@@ -64,6 +64,9 @@ public function testSkipNestedErrors()
         $container->register('foo', 'stdClass')
             ->addArgument(new Reference('bar', ContainerBuilder::RUNTIME_EXCEPTION_ON_INVALID_REFERENCE));
 
+        $container->register('baz', 'stdClass')
+            ->addArgument(new Reference('bar', ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE));
+
         $pass = new DefinitionErrorExceptionPass();
         $pass->process($container);