Skip to content

Commit aafbe05

Browse files
minor symfony#61321 [Contracts] replace #[TestWithJson] with #[TestWith] (xabbuh)
This PR was merged into the 7.4 branch. Discussion ---------- [Contracts] replace #[TestWithJson] with #[TestWith] | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT PHP CS fixer replaces the ``@testWith`` annotation with the `#[TestWithJson]` attribute, but I feel like using `#[TestWith]` makes it more obvious what we are going to test. Commits ------- f793bcc replace #[TestWithJson] with #[TestWith]
2 parents cd45355 + f793bcc commit aafbe05

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace Symfony\Contracts\HttpClient\Test;
1313

1414
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
15-
use PHPUnit\Framework\Attributes\TestWithJson;
15+
use PHPUnit\Framework\Attributes\TestWith;
1616
use PHPUnit\Framework\TestCase;
1717
use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
1818
use Symfony\Contracts\HttpClient\Exception\RedirectionExceptionInterface;
@@ -347,8 +347,8 @@ public function test304()
347347
* @testWith [[]]
348348
* [["Content-Length: 7"]]
349349
*/
350-
#[TestWithJson('[[]]')]
351-
#[TestWithJson('[["Content-Length: 7"]]')]
350+
#[TestWith([[]])]
351+
#[TestWith([['Content-Length: 7']])]
352352
public function testRedirects(array $headers = [])
353353
{
354354
$client = $this->getHttpClient(__FUNCTION__);

0 commit comments

Comments
 (0)