Skip to content

Conversation

@brendo
Copy link
Member

@brendo brendo commented Jan 17, 2019

Closes #37

This handles a bug raised by @kmeinke some time ago.

I don't believe the fix is as difficult as thought:

  • $transformer is a private variable. If someone's using it, it's on them 🙅‍♂️
  • This value is not persisted to disk for each datasource, so there's no migration required and simply updating the extension will enable them to get the benefit.

@brendo brendo requested a review from nitriques January 17, 2019 04:41
@brendo
Copy link
Member Author

brendo commented Feb 26, 2019

Bump too 👍 Similar deal, I think this can be merged.

@brendo brendo merged commit c7d6e23 into master Feb 28, 2019
@brendo brendo deleted the fix_issue-37-mixing-formats branch February 28, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixing datasource formats on one page fails

2 participants