Currency repository #199
Merged
Currency repository #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovitrif
approved these changes
Jun 18, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Nice!
Added a comment about the duplicate caching, which is ok to just fix with a deprecation annotation on the service method loadCachedRates(), which is used in multiple places.
Just wanting to make sure we don't forget about this, if it's a must to merge asap so progress on the high-balance-warning is unblocked.
4 tasks
ovitrif
pushed a commit
that referenced
this pull request
Nov 5, 2025
… details This PR adds boosted txids tracking and displays parent transaction IDs in the activity details, matching iOS PR #199. ## Changes - Added `boostTxIds: List<String>` field to `PendingBoostActivity` to store parent transaction IDs - **CPFP**: Append child transaction ID to parent's `boostTxIds` when boosting - **RBF**: Track parent chain (existing `boostTxIds` + current txId) in `PendingBoostActivity`. Store parent txIds when creating replacement, retrieve and apply when replacement syncs - **UI**: Display boosted transaction IDs in `ActivityDetailScreen` with labels "BOOSTED TRANSACTION {num} (CPFP)" or "BOOSTED TRANSACTION {num} (RBF)" based on transaction direction ### Implementation Details 1. **PendingBoostActivity DTO**: Added `boostTxIds` field to track parent transaction IDs for RBF 2. **BoostTransactionViewModel**: - Updated `cachePendingBoostActivity()` to track parent chain for RBF (existing boostTxIds + current txId) - Updated `handleCPFPUpdate()` to append child txId to parent's boostTxIds 3. **ActivityRepo**: Updated `boostPendingActivities()` to apply tracked boostTxIds when processing pending boosts 4. **ActivityDetailScreen**: Added UI section to display boosted transaction IDs with appropriate labels This matches the behavior implemented in bitkit-ios PR #199.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the business logic and states from the CurrencyViewModel to a repository so they can be shared across other ViewModels
CurrencyRepoRelated to #195
Necessary to #196