feat: geoblocking build config override #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a build configuration option to disable geoblocking checks entirely via the GEO environment variable, primarily for E2E testing purposes. When GEO=false, API-based geoblocking checks are bypassed while preserving the default enabled behavior.
- Introduces
GEObuild configuration flag with default valuetrue - Adds early return in geoblocking logic when disabled via config
- Updates E2E workflow and documentation to use the new flag
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/build.gradle.kts | Adds GEO build config field with environment variable support |
| app/src/main/java/to/bitkit/env/Env.kt | Exposes geoblocking config as constant |
| app/src/main/java/to/bitkit/services/CoreService.kt | Implements early return when geoblocking disabled |
| README.md | Documents the new GEO environment variable usage |
| .github/workflows/e2e.yml | Configures E2E tests to disable geoblocking |
jvsena42
reviewed
Oct 9, 2025
| invoice = cjitOrder.invoice.request, | ||
| invoice = cjitEntry.invoice.request, | ||
| message = "", | ||
| timestamp = now, |
Member
There was a problem hiding this comment.
The time parameter could have a less error-prone name, like timestampSeconds
jvsena42
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Resolves review comments in #429
Description
This PR adds setup to disable geoblocking checks entirely via
GEObool environment variable with valuetrueorfalse.When using
GEO=false, geoblocking checks via API are bypassed.Defaults to
true, preserving current default functionality.Mainly relevant for E2E tests.
Aside, it also addressed comments for merged PR:
cjitOrdertocjitEntryin codebase, because it is not an order more than it is an invoice.Preview
geoOff.mp4
QA Notes
test
GEO=false ./gradlew installDevDebugVERBOSE: Geoblocking disabled via build config(optional) CJIT test
/regtest-mine 6