Test/boost #213
Merged
Test/boost #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds accessibility identifiers to support E2E testing for the boost transaction feature, which allows users to speed up pending Bitcoin transactions using either RBF (Replace-By-Fee) or CPFP (Child-Pays-For-Parent) methods.
- Adds accessibility identifiers to boost-related UI components for automated testing
- Implements navigation reset after successful boost completion
- Enables boost E2E tests in the CI/CD workflow
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Bitkit/Views/Wallets/Sheets/BoostSheet.swift | Added accessibility identifiers for boost UI controls and navigation reset on completion |
| Bitkit/Views/Wallets/Activity/ActivityItemView.swift | Added conditional status accessibility identifiers and restructured amount/fee identifiers |
| Bitkit/Views/Wallets/Activity/ActivityIcon.swift | Wrapped icon in Group and added boosting icon identifier |
| Bitkit/Views/Wallets/Activity/ActivityExplorerView.swift | Extended InfoSection to support test identifiers for TXID and boost transaction references |
| Bitkit/Components/SheetIntro.swift | Added accessibility identifiers to sheet intro components using baseTestID pattern |
| Bitkit/Components/NavigationBar.swift | Added accessibility identifier to navigation back button |
| .github/workflows/e2e-tests.yml | Added @boost tag to E2E test workflow |
This was referenced Nov 10, 2025
piotr-iohk
force-pushed
the
test/boost
branch
from
b77a353 to
23319f8
Compare
ovitrif
approved these changes
Nov 13, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
LGTM code-wise.
Untested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling boost tests and accompanying adjustments.
Linked Issues/Tasks
Related:
synonymdev/bitkit-e2e-tests#44
synonymdev/bitkit-android#462
Screenshot / Video
Insert relevant screenshot / recording