BDK 1.0.0-alpha.11 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovitrif
approved these changes
Aug 14, 2024
| static func createNewWallet(bip39Passphrase: String?, walletIndex: Int = 0) throws -> String { | ||
| let mnemonic = Mnemonic(wordCount: Env.defaultWalletWordCount).asString() | ||
|
|
||
Collaborator
There was a problem hiding this comment.
Sir, can you please use SwiftFormat? It has a nice extension that auto-formats on ⌘ S in XCode: SwiftFormat for Xcode.
If anything, to make it simple, we can go with the default config so no time is wasted on configuring it.
Reason:
Trailing and random whitespaces are not nice.
Contributor
Author
There was a problem hiding this comment.
Yeah no problem sounds good. Made an issue here I'll do a separate PR with just the formatting updates.
2 tasks
Closed
ovitrif
approved these changes
Aug 14, 2024
ovitrif
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullScan()(used for restoring or manually rescanning wallet) andsyncWithRevealedSpks()(used for refreshing the wallet and only scanning addresses that have been exposed)Notes:
Currently looks like alpha release is missing wallet data persistence after syncing so balance is missing until refreshed each tie app is open. Waiting on the beta release for bdk-ffi for this as building straight from master is currently broken.