Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Nov 20, 2025

Description

This PR update LDK dependency to fix android build

Linked Issues/Tasks

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

N/A

QA Notes

Run

yarn start
# in another terminal
yarn android

The android app should run

@jvsena42 jvsena42 self-assigned this Nov 20, 2025
@socket-security
Copy link

socket-security bot commented Nov 20, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​synonymdev/​react-native-ldk@​0.0.161 ⏵ 0.0.16379 +110073 +188 -1100

View full report

@ovitrif
Copy link
Contributor

ovitrif commented Nov 20, 2025

@catch-21 does this look ok as the desired approach for the release/merge process?!

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK,

testin ♻️ …

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested android build ✅

@ovitrif ovitrif merged commit 4ed0b0e into fix/backup-client Nov 20, 2025
6 of 7 checks passed
@ovitrif ovitrif deleted the chore/update-ldk-dependency branch November 20, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants