Skip to content

Conversation

@Roang-zero1
Copy link
Contributor

Make it clear that is.convert does not validate the parameters passed to the
created function.
Addresses #12

@Roang-zero1
Copy link
Contributor Author

In this pull request I've also updated the editorconfig to allow line-breaks in Markdown files (allow trailing white-spaces).
An alternative would be to use \ I would like input on what is preferred.

Make it clear that is.convert does not validate the parameters passed to the
created function.
* Allow line breaks in markdown documents
Address linting for updated documentation.
@wooorm
Copy link
Member

wooorm commented Dec 8, 2019

Thanks @Roang-zero1 for mentioning this in the docs!

<br>s or whole emphasised sentences are typically not semantic, so I instead opted to rewrite the sentence a bit. Let me know if you don’t feel my wording captures what you intended to write and we can make it clearer!

@wooorm wooorm changed the title Update README for is.convert Add clarification on differences of is.convert Dec 8, 2019
@wooorm wooorm merged commit 8c0a649 into syntax-tree:master Dec 8, 2019
@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 📚 area/docs This affects documentation labels Dec 8, 2019
@Roang-zero1
Copy link
Contributor Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 area/docs This affects documentation 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Development

Successfully merging this pull request may close these issues.

3 participants