Skip to content

Fix example to use ESM #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix example to use ESM #22

merged 2 commits into from
Apr 20, 2021

Conversation

@coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Apr 20, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Updated examples from README to ESM

@wooorm wooorm changed the title docs: readme: update examples to ESM Fix example to use ESM Apr 20, 2021
wooorm
wooorm requested changes Apr 20, 2021
View reviewed changes
@coderaiser @wooorm
docs: readme: changed to named
19bfec9 
Co-authored-by: Titus <tituswormer@gmail.com>
@wooorm wooorm merged commit a14d311 into syntax-tree:main Apr 20, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 20, 2021
@wooorm
Copy link
Member

wooorm commented Apr 20, 2021

thank you!

@wooorm wooorm added the 📚 area/docs This affects documentation label Apr 20, 2021
@coderaiser
Copy link
Contributor Author

coderaiser commented Apr 20, 2021

Little bit sad that v8-compile-cache would be unavailable, it doesn't support ESM, but used by tools like postcss, eslint, etc. It boosts about 20% to speed of starting CLI apps.

@coderaiser coderaiser deleted the patch-1 branch April 20, 2021 16:58
@wooorm
Copy link
Member

wooorm commented Apr 20, 2021

Yup, and webpack. It seems to be a big bottle neck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

📚 area/docs This affects documentation 💪 phase/solved Post is done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coderaiser @wooorm