Workplace location #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
does not include size variables but DOES include the omx/skim data which is the hard/new part
Conflicts: activitysim/activitysim.py activitysim/defaults/variables.py Also importing omx from external library and have tested the models to make sure they are working (they are)
example/models.py
Outdated
Contributor
There was a problem hiding this comment.
This is still pulling omx from activitysim.
it looks like I still had .pyc files lying around so it was still using the activitysim omx file - now using the right one and made a couple of small changes to use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code required to get the workplace location model to work. It is now up-to-date with the external OMX code and is working and ready to merge.