Skip to content

Conversation

@airadier
Copy link
Collaborator

@airadier airadier commented Nov 6, 2023

What this PR does / why we need it:

registry-scanner has a new environment variable to write a memory profile (heap dump) periodically to a folder.

This version bumps the registry-scanner to 0.2.56 to include that functionality and adds an option to specify a PVC. When that option is set, the PVC is mounted, mem profile enabled, and the dumps will be written to the PVC

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Nov 6, 2023
@airadier airadier marked this pull request as ready for review November 6, 2023 17:53
@airadier airadier requested review from a team as code owners November 6, 2023 17:53
@airadier airadier requested a review from hayk99 November 6, 2023 17:53
@airadier airadier changed the title Add flag to enable mem profile dumps on a PVC feat(registry-scanner): Add flag to enable mem profile dumps on a PVC Nov 6, 2023
@github-actions github-actions bot dismissed their stale review November 6, 2023 17:54

All good!

@airadier airadier merged commit 022c547 into master Nov 6, 2023
@airadier airadier deleted the registry-scanner-add-mem-profiling-flag branch November 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-tests Chart templates modified without test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants